Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add caseSensitiveHttpHeaders to appolicy crd #3133

Merged
merged 2 commits into from
Oct 10, 2022

Conversation

galitskiy
Copy link
Contributor

@galitskiy galitskiy commented Oct 7, 2022

Proposed changes

Add the missing bot-defense caseSensitiveHttpHeaders setting to APPolicy CRD. Resolves #3111

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Copy link
Member

@lucacome lucacome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @galitskiy ! And thanks for upgrading controller-tools 🙂

@lucacome lucacome requested review from a team, haywoodsh, jjngx and shaun-nx October 7, 2022 23:01
@lucacome lucacome self-assigned this Oct 7, 2022
@jjngx jjngx requested a review from a team October 10, 2022 09:10
@lucacome lucacome merged commit 184eb94 into nginxinc:main Oct 10, 2022
coolbry95 pushed a commit to coolbry95/kubernetes-ingress that referenced this pull request Nov 18, 2022
@lucacome lucacome added the enhancement Pull requests for new features/feature enhancements label Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Pull requests for new features/feature enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The caseSensitiveHttpHeaders property is not available in APPolicy CRD
4 participants