Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add controller.dnsPolicy to the helm chart #3136

Merged

Conversation

wd
Copy link
Contributor

@wd wd commented Oct 8, 2022

Proposed changes

Add controller.dnsPolicy to the values file of the helm chart.
Related issue: #3135

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Oct 8, 2022
@wd
Copy link
Contributor Author

wd commented Oct 8, 2022

Regarding the docs from k8s, the default value of dnsPolicy is ClusterFirst. So I set the same in the values file.

$ k explain deployment.spec.template.spec.dnsPolicy
KIND:     Deployment
VERSION:  apps/v1

FIELD:    dnsPolicy <string>

DESCRIPTION:
     Set DNS policy for the pod. Defaults to "ClusterFirst". Valid values are
     'ClusterFirstWithHostNet', 'ClusterFirst', 'Default' or 'None'. DNS
     parameters given in DNSConfig will be merged with the policy selected with
     DNSPolicy. To have DNS options set along with hostNetwork, you have to
     specify DNS policy explicitly to 'ClusterFirstWithHostNet'.

$ k explain daemonset.spec.template.spec.dnsPolicy
KIND:     DaemonSet
VERSION:  apps/v1

FIELD:    dnsPolicy <string>

DESCRIPTION:
     Set DNS policy for the pod. Defaults to "ClusterFirst". Valid values are
     'ClusterFirstWithHostNet', 'ClusterFirst', 'Default' or 'None'. DNS
     parameters given in DNSConfig will be merged with the policy selected with
     DNSPolicy. To have DNS options set along with hostNetwork, you have to
     specify DNS policy explicitly to 'ClusterFirstWithHostNet'.

@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2022

Codecov Report

Merging #3136 (b3345ea) into main (15a1fdf) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3136      +/-   ##
==========================================
+ Coverage   52.54%   52.56%   +0.01%     
==========================================
  Files          58       58              
  Lines       16069    16069              
==========================================
+ Hits         8444     8446       +2     
+ Misses       7349     7347       -2     
  Partials      276      276              
Impacted Files Coverage Δ
...ternal/k8s/appprotect/app_protect_configuration.go 86.74% <0.00%> (+0.57%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@lucacome lucacome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @wd thanks for the PR!

@lucacome lucacome self-assigned this Oct 12, 2022
@lucacome lucacome requested review from a team, haywoodsh, ciarams87 and jjngx October 12, 2022 05:21
@lucacome lucacome added this to the v2.5.0 milestone Oct 13, 2022
@lucacome lucacome merged commit 52bd65e into nginxinc:main Oct 14, 2022
coolbry95 pushed a commit to coolbry95/kubernetes-ingress that referenced this pull request Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants