Report ingress status #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the address field in the status of Ingresses resources. The source for the external status can be a service of type LoadBalancer, or a config map key specifying the address to report. New command-line arguments: report-ingress-status, external-service string, and enable-leader-election. New config map key: external-status-address. Uses Leader Election, if enabled, to avoid multiple Ingress controllers attempting to update ingress status.
isaachawley
added
the
enhancement
pleshakov
suggested changes
Jul 27, 2018
| } | ||
|
|
||
| // UpdateManagedAndMergeableIngresses handles the full return format of LoadBalancerController.getManagedIngresses | ||
| func (su *StatusUpdater) UpdateManagedAndMergeableIngresses(managedIngresses []v1beta1.Ingress, mExes map[string]*nginx.MergeableIngresses) error { |
- Was ignoring changed Ingresses instead of unchanged - Change names of mExes to mergableIngExes
pleshakov
approved these changes
Jul 31, 2018
|
Ignore the jenkins check for this one |
1 similar comment
|
Ignore the jenkins check for this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the address field in the status of Ingresses resources. The source for the status address can be a service of type LoadBalancer, or a config map key specifying the address to report.
New command-line arguments: report-ingress-status, external-service, and enable-leader-election.
New config map key: external-status-address.
Uses Leader Election, if enabled, to avoid multiple Ingress controllers attempting to update ingress status.
Fixes the following issues:
Checklist
Before creating a PR, run through this checklist and mark each as complete.