Fix find ingress for secret ns bug #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaachawley
approved these changes
Jul 31, 2018
peterkellydev
approved these changes
Jul 31, 2018
pleshakov
approved these changes
Jul 31, 2018
|
Ignore the pr-merge jenkins check please |
Dean-Coakley
force-pushed
the
fix-findIngressForSecret-ns-bug
branch
from
7b156d0
to
38065b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
findIngressForSecret now ensures that it searches for an ingress in the same namespace as the passed in secret
Included in this pr are:
No documentation changes were required in this PR
Checklist
Before creating a PR, run through this checklist and mark each as complete.