Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add label for Helm Chart #3284

Merged
merged 2 commits into from
Nov 24, 2022
Merged

Add label for Helm Chart #3284

merged 2 commits into from
Nov 24, 2022

Conversation

lucacome
Copy link
Member

@lucacome lucacome commented Nov 19, 2022

This adds configuration for automatically labeling PRs with helm_chart when there's a change to any of the files in the helm chart directory.
We use those labels to create the sections in the releases, so this change will add a new Helm Chart section if we had any PRs modifying the helm chart.

Since we're having quite a few PRs modifying the helm chart, this will group them together and "highlight" them.

@lucacome lucacome requested a review from a team as a code owner November 19, 2022 01:48
@lucacome lucacome self-assigned this Nov 19, 2022
@github-actions github-actions bot added the chore Pull requests for routine tasks label Nov 19, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2022

Codecov Report

Merging #3284 (ad52e4b) into main (02b5896) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3284      +/-   ##
==========================================
+ Coverage   52.64%   52.68%   +0.03%     
==========================================
  Files          59       59              
  Lines       16107    16107              
==========================================
+ Hits         8480     8486       +6     
+ Misses       7343     7339       -4     
+ Partials      284      282       -2     
Impacted Files Coverage Δ
internal/k8s/configuration.go 95.76% <0.00%> (+0.36%) ⬆️
...ternal/k8s/appprotect/app_protect_configuration.go 86.74% <0.00%> (+0.57%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@tomasohaodha tomasohaodha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add more detail to the PR description for those not as familiar as you with github actions? "Adds label for Helm Chart changes." is factual but not helpful - we want PRs to be a learning tool not just a review tool. Thanks

@lucacome
Copy link
Member Author

@tomasohaodha added more context.

@lucacome lucacome merged commit c68a0b0 into main Nov 24, 2022
@lucacome lucacome deleted the chore/add-helm-label branch November 24, 2022 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants