Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add websocket protocol option to monitor directive #3442

Merged
merged 3 commits into from
Jan 19, 2023
Merged

Add websocket protocol option to monitor directive #3442

merged 3 commits into from
Jan 19, 2023

Conversation

pasmant
Copy link
Contributor

@pasmant pasmant commented Jan 16, 2023

Add websocket protocol option to monitor directive

example:

app_protect_dos_monitor uri=webapp.example.com protocol=websocket timeout=5;

  • [V] I have read the CONTRIBUTING doc
  • [V] I have added tests that prove my fix is effective or that my feature works
  • [V] I have checked that all unit tests pass after adding my changes
  • [V] I have updated necessary documentation
  • [V] I have rebased my branch onto main
  • [V] I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added documentation Pull requests/issues for documentation helm_chart Pull requests that update the Helm Chart labels Jan 16, 2023
@pasmant pasmant marked this pull request as ready for review January 17, 2023 13:02
@pasmant pasmant requested a review from a team as a code owner January 17, 2023 13:02
@shaun-nx shaun-nx self-requested a review January 17, 2023 14:42
@shaun-nx shaun-nx self-assigned this Jan 17, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #3442 (841626b) into main (d51a554) will decrease coverage by 0.03%.
The diff coverage is n/a.

❗ Current head 841626b differs from pull request most recent head 5fee706. Consider uploading reports for the commit 5fee706 to get more accurate results

@@            Coverage Diff             @@
##             main    #3442      +/-   ##
==========================================
- Coverage   51.95%   51.93%   -0.03%     
==========================================
  Files          60       60              
  Lines       16797    16797              
==========================================
- Hits         8727     8723       -4     
- Misses       7775     7777       +2     
- Partials      295      297       +2     
Impacted Files Coverage Δ
pkg/apis/dos/validation/dos.go 94.54% <ø> (ø)
internal/k8s/configuration.go 95.39% <0.00%> (-0.37%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shaun-nx shaun-nx merged commit b92ac45 into main Jan 19, 2023
@shaun-nx shaun-nx deleted the websocket branch January 19, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation helm_chart Pull requests that update the Helm Chart
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants