Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Helm Chart Schema for priorityClassName #3448

Merged
merged 3 commits into from
Jan 18, 2023
Merged

Fix Helm Chart Schema for priorityClassName #3448

merged 3 commits into from
Jan 18, 2023

Conversation

lucacome
Copy link
Member

  • Fixes wrong schema for priorityClassName
  • Fixes Ingress Controller capitalization in all the docs

@lucacome lucacome requested a review from a team January 18, 2023 00:26
@lucacome lucacome requested a review from a team as a code owner January 18, 2023 00:26
@lucacome lucacome self-assigned this Jan 18, 2023
@github-actions github-actions bot added chore Pull requests for routine tasks documentation Pull requests/issues for documentation helm_chart Pull requests that update the Helm Chart labels Jan 18, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #3448 (5ada80d) into main (e439f67) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3448   +/-   ##
=======================================
  Coverage   51.95%   51.95%           
=======================================
  Files          60       60           
  Lines       16797    16797           
=======================================
  Hits         8727     8727           
  Misses       7775     7775           
  Partials      295      295
Impacted Files Coverage Δ
internal/k8s/controller.go 11.96% <ø> (ø)
pkg/apis/externaldns/validation/externaldns.go 95.89% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lucacome lucacome changed the title Fix Chart Schema for priorityClassName Fix Helm Chart Schema for priorityClassName Jan 18, 2023
@lucacome lucacome merged commit d51a554 into main Jan 18, 2023
@lucacome lucacome deleted the chore/fix-schema branch January 18, 2023 18:27
lucacome added a commit that referenced this pull request Jan 25, 2023
@lucacome
Fix Helm Chart Schema for priorityClassName (#3448)
c5cfbc6 
* Fix Chart Schema for priorityClassName

* Fix IC capitalization in docs

(cherry picked from commit d51a554)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonwilliams14 jasonwilliams14 jasonwilliams14 approved these changes

@jjngx jjngx jjngx approved these changes

@shaun-nx shaun-nx shaun-nx approved these changes

@haywoodsh haywoodsh Awaiting requested review from haywoodsh haywoodsh is a code owner automatically assigned from nginxinc/kic

Assignees

@lucacome lucacome

Labels
chore Pull requests for routine tasks documentation Pull requests/issues for documentation helm_chart Pull requests that update the Helm Chart
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lucacome @codecov-commenter @jasonwilliams14 @jjngx @shaun-nx