fix: controller.topologySpreadConstraints schema

[marcuz]

Proposed changes

Fixes error:

controller.topologySpreadConstraints: Invalid type. Expected: object, given: array

Expected YAML:

controller:
  topologySpreadConstraints:
    - maxSkew: 1
      topologyKey: topology.kubernetes.io/zone
      whenUnsatisfiable: DoNotSchedule
      labelSelector:
        matchLabels:
          app: nginx-ingress
    - maxSkew: 1
      topologyKey: kubernetes.io/hostname
      whenUnsatisfiable: DoNotSchedule
      labelSelector:
        matchLabels:
          app: nginx-ingress

Checklist

Before creating a PR, run through this checklist and mark each as complete.

• I have read the CONTRIBUTING doc
• I have added tests that prove my fix is effective or that my feature works
• I have checked that all unit tests pass after adding my changes
• I have updated necessary documentation
• I have rebased my branch onto main
• I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

[codecov-commenter]

Codecov Report

Merging #3527 (49a6be2) into main (9b435ad) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 49a6be2 differs from pull request most recent head 4fb481f. Consider uploading reports for the commit 4fb481f to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #3527      +/-   ##
==========================================
+ Coverage   51.98%   52.00%   +0.02%     
==========================================
  Files          60       60              
  Lines       16816    16816              
==========================================
+ Hits         8742     8746       +4     
+ Misses       7777     7775       -2     
+ Partials      297      295       -2     

Impacted Files	Coverage Δ
internal/k8s/configuration.go	95.79% <0.00%> (+0.36%)	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[lucacome]

Hi @marcuz I think we just need to change the ref to the right definition and everything else can remain the same

[marcuz]

@lucacome sorry I totally misunderstood the behaviour of $ref here. Pushing a cleanup commit soon!

[marcuz]

Just changing the $ref as suggested, lint passes successfully:

$ helm lint . -f values.yaml -f values-test.yaml 
==> Linting .

1 chart(s) linted, 0 chart(s) failed

values-test.yaml contains the controller.topologySpreadConstraints as specified above.

[lucacome]

Thanks @marcuz !

[marcuz]

Thanks @marcuz !

Sorry for all the back and forth. 😄

[cpuengr949]

@lucacome I am getting this same error using terraform to build
topologySpreadConstraints = [
{
labelSelector = {
matchLabels = {
app = "nginx-plus-nginx-ingress"
}
}
maxSkew = 1
topologyKey = "kubernetes.io/hostname"
whenUnsatisfiable = "DoNotSchedule"
}
]

Which is creating the code
"topologySpreadConstraints":
- "labelSelector":
"matchLabels":
"app": "nginx-plus-nginx-ingress"
"maxSkew": 1
"topologyKey": "kubernetes.io/hostname"
"whenUnsatisfiable": "DoNotSchedule"

[lucacome]

@cpuengr949 even with the fix in this PR?

[cpuengr949]

@lucacome How do I get the fix?
I believe terraform downloads it each time right?
Thank You

[lucacome]

@cpuengr949 if it's pulling the main branch from here or using the edge helm chart, it should have the fix in this PR, but I don't know what your setup is 🙂