Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use OIDC to login to AWS #3740

Merged
merged 1 commit into from
Apr 11, 2023
Merged

Use OIDC to login to AWS #3740

merged 1 commit into from
Apr 11, 2023

Conversation

lucacome
Copy link
Member

@lucacome lucacome commented Apr 7, 2023

Proposed changes

This PR updates the workflows to use OIDC to log in to AWS using short-lived tokens instead of static keys.

From the docs:

OpenID Connect (OIDC) allows your GitHub Actions workflows to access resources in Amazon Web Services (AWS), without needing to store the AWS credentials as long-lived GitHub secrets.

@lucacome lucacome self-assigned this Apr 7, 2023
@lucacome lucacome requested a review from a team as a code owner April 7, 2023 22:27
@github-actions github-actions bot added the chore Pull requests for routine tasks label Apr 7, 2023
@codecov
Copy link

codecov bot commented Apr 7, 2023

Codecov Report

Merging #3740 (736d71d) into main (76a6ffe) will decrease coverage by 0.03%.
The diff coverage is n/a.

❗ Current head 736d71d differs from pull request most recent head 4b70c87. Consider uploading reports for the commit 4b70c87 to get more accurate results

@@            Coverage Diff             @@
##             main    #3740      +/-   ##
==========================================
- Coverage   52.35%   52.33%   -0.03%     
==========================================
  Files          59       59              
  Lines       16880    16880              
==========================================
- Hits         8838     8834       -4     
- Misses       7747     7749       +2     
- Partials      295      297       +2     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@jasonwilliams14 jasonwilliams14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty straightforward. Clear and concise.

@lucacome lucacome merged commit ff70e91 into main Apr 11, 2023
@lucacome lucacome deleted the chore/oidc-login-aws branch April 11, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants