added serviceNameOverride

[timnee]

Proposed changes

Add a name override to the helm controller-server template. This can be used to prevent cloud load balancers from being replaced due to service name change during helm upgrades. This addresses #3752

Checklist

Before creating a PR, run through this checklist and mark each as complete.

• I have read the CONTRIBUTING doc
• I have added tests that prove my fix is effective or that my feature works
• I have checked that all unit tests pass after adding my changes
• I have updated necessary documentation
• I have rebased my branch onto main
• I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

[coolbry95]

I think if a change like this is made it should be for all resources not just one by one. Maybe fullNameOverride should be for all resources and it should not append "-nginx-ingress".

[timnee]

I think if a change like this is made it should be for all resources not just one by one. Maybe fullNameOverride should be for all resources and it should not append "-nginx-ingress".

The problem I'm trying to solve requires the names to be different. Please see #3752 (comment)

[lucacome]

@coolbry95 we already support fullnameOverride and nameOverride, but there's no way to use it for this use-case

[lucacome]

@timnee thanks for the fix, and sorry again for the mishap!

[codecov]

Codecov Report

Merging #3802 (6423b54) into main (87b8a58) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3802   +/-   ##
=======================================
  Coverage   52.39%   52.39%           
=======================================
  Files          59       59           
  Lines       16902    16902           
=======================================
  Hits         8855     8855           
  Misses       7750     7750           
  Partials      297      297           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more