Fix Configmap/Mergeable Ingress Add/Update event logging #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Bug introduced in: cca1389 * Changed the logged bug to reference the correct variable * Built the eventMessage string prior to log to preserve code structure while not printing errs when they are nil
* Bug introduced in: cca1389 * Changed the logged bug to the correct variable * Built the bug string prior to log to preserve code structure while not printing errs when they are nil
Dean-Coakley
force-pushed
the
fix-ing-err-events
branch
from
743ffe7
to
9b5736c
Compare
pleshakov
approved these changes
Oct 2, 2018
isaachawley
approved these changes
Oct 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
nilis no longer printednilis no longer printedChecklist
Before creating a PR, run through this checklist and mark each as complete.