-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for controller.selectorLabels
#3977
Add support for controller.selectorLabels
#3977
Conversation
@hanyouqing Thank you for the PR. We are currently reviewing this on our side and trying to reproduce the issue. If you could respond to our request for additional information in the issue thread you created, that would be great. Thank you. |
Thanks for your reply! I'm glad to share the reproduce steps, but I can't reproduce it with Helm. We manage the helm chart with Terraform, It might be some issues for the helm Terraform provider. Let me figure it out, if so I'll close the pr. |
Hi @jasonwilliams14, I've added some comments and how to reproduce it see the issue page #3976 (comment). |
controller.selectorLabels
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @hanyouqing
Signed-off-by: Luca Comellini <luca.com@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #3977 +/- ##
==========================================
- Coverage 51.87% 51.84% -0.03%
==========================================
Files 59 59
Lines 16710 16710
==========================================
- Hits 8668 8664 -4
- Misses 7745 7747 +2
- Partials 297 299 +2 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Proposed changes
Fix issue #3976
Checklist
Before creating a PR, run through this checklist and mark each as complete.