Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve NGINX start #403

Merged
merged 1 commit into from
Oct 25, 2018
Merged

Improve NGINX start #403

merged 1 commit into from
Oct 25, 2018

Conversation

pleshakov
Copy link
Contributor

@pleshakov pleshakov commented Oct 23, 2018

Proposed changes

Improve how the IC starts NGINX

For NGINX and NGINX Plus:

  • After the IC starts NGINX, check that NGINX is running by
    querying the config version via the unix socket -- the same check
    that is performed after each configuration reload.
  • Modify the check to always sleep before the first check.

For NGINX Plus:

  • Remove no longer required 0.5s timeout during the IC start.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

Copy link
Contributor

@isaachawley isaachawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

For NGINX and NGINX Plus:
- After the IC starts NGINX, check that NGINX is running by
querying the config version via the unix socket -- the same check
that is performed after each configuration reload.
- Modify the check to always sleep before the first check.

For NGINX Plus:
- Remove no longer required 0.5s timeout during the IC start.
@pleshakov pleshakov merged commit 814c10f into master Oct 25, 2018
@pleshakov pleshakov deleted the improve-nginx-start branch October 25, 2018 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants