Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify language about default TLS certificate on helm chart #4084

Merged

Conversation

danielnginx
Copy link
Collaborator

Proposed changes

Clarify the language about default TLS on helm chart, from NGINX Ingress Controller release 3.1 by default, a pre-generated self-signed certificate is NOT used anymore.

Helm chart values and installation documentation were updated.

This pull request address the following issue: #3730

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Update the the helm chart comments and helm chart installation documentation.
@danielnginx danielnginx requested a review from a team as a code owner July 10, 2023 10:59
@github-actions github-actions bot added documentation Pull requests/issues for documentation helm_chart Pull requests that update the Helm Chart labels Jul 10, 2023
@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Merging #4084 (824de2a) into main (fd7fc2b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #4084   +/-   ##
=======================================
  Coverage   51.87%   51.87%           
=======================================
  Files          59       59           
  Lines       16710    16710           
=======================================
  Hits         8668     8668           
  Misses       7745     7745           
  Partials      297      297           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vepatel vepatel requested a review from a team July 10, 2023 12:34
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shaun-nx shaun-nx merged commit be164f0 into nginxinc:main Jul 17, 2023
58 checks passed
@danielnginx danielnginx deleted the clarify-language-about-default-tls branch July 18, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation helm_chart Pull requests that update the Helm Chart
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants