Generate mainfests automatically from Helm #4278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
lucacome
force-pushed
the
feat/generate-manifests-from-helm
branch
from
8a8c717
to
19cc9bb
Compare
Codecov Report
@@ Coverage Diff @@
## main #4278 +/- ##
=======================================
Coverage 51.97% 51.97%
=======================================
Files 59 59
Lines 16962 16962
=======================================
Hits 8816 8816
Misses 7849 7849
Partials 297 297
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
lucacome
force-pushed
the
feat/generate-manifests-from-helm
branch
from
697a111
to
1ff8b7a
Compare
ADubhlaoich
approved these changes
Aug 28, 2023
shaun-nx
reviewed
Aug 29, 2023
shaun-nx
reviewed
Aug 29, 2023
shaun-nx
reviewed
Aug 29, 2023
lucacome
force-pushed
the
feat/generate-manifests-from-helm
branch
3 times, most recently
from
3a20bd6
to
4fc8248
Compare
lucacome
force-pushed
the
feat/generate-manifests-from-helm
branch
from
cfd90f4
to
1512776
Compare
lucacome
changed the title
vepatel
reviewed
Oct 24, 2023
lucacome
force-pushed
the
feat/generate-manifests-from-helm
branch
from
4d2d3c9
to
5229fc0
Compare
shaun-nx
approved these changes
Nov 1, 2023
shaun-nx
reviewed
Nov 1, 2023
lucacome
force-pushed
the
feat/generate-manifests-from-helm
branch
from
f448169
to
0909984
Compare
vepatel
reviewed
Nov 2, 2023
charts/nginx-ingress/README.md
Outdated
| @@ -100,15 +100,15 @@ CRDs](#upgrading-the-crds). | |||
| To upgrade the release `my-release`: | |||
|
|
|||
| ```console | |||
| helm upgrade my-release oci://ghcr.io/nginxinc/charts/nginx-ingress --version 1.0.1 | |||
| helm upgrade my-release -n nginx-ingress oci://ghcr.io/nginxinc/charts/nginx-ingress --version 1.0.1 | |||
There was a problem hiding this comment.
according to old command the installation was in default ns and now user is running upgrade in a different ns? I understand that these command as a guide but most users usually straight-up copy-paste and upgrade will fail due to ownership of clusterroles as well.
There was a problem hiding this comment.
How do you propose we change it?
There was a problem hiding this comment.
by leaving it to default? and giving user the option to set namespace maybe
shaun-nx
reviewed
Nov 2, 2023
lucacome
force-pushed
the
feat/generate-manifests-from-helm
branch
4 times, most recently
from
6260c58
to
b0fc3f9
Compare
jasonwilliams14
approved these changes
Nov 2, 2023
lucacome
force-pushed
the
feat/generate-manifests-from-helm
branch
2 times, most recently
from
4638bc0
to
2e9caa4
Compare
Uses Helm Charts in examples/helm-chart to template single file manifests in deploy/.
lucacome
force-pushed
the
feat/generate-manifests-from-helm
branch
from
2e9caa4
to
e7b5228
Compare
lucacome
added a commit
that referenced
this pull request
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Uses Helm Charts in examples/helm-chart to template single file manifests in
deploy/.