Add tutorial doc for VirtualServer configuration with Custom Listener Ports #4294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaun-nx
requested review from
brianehlert,
ADubhlaoich,
haywoodsh,
jasonwilliams14,
vepatel and
jjngx
github-actions
bot
added
the
documentation
vepatel
reviewed
Aug 25, 2023
docs/content/configuration/virtualserver-and-virtualserverroute-resources.md
Outdated
Show resolved
Hide resolved
vepatel
reviewed
Aug 25, 2023
docs/content/tutorials/virtual-server-with-custom-listener-ports.md
Outdated
Show resolved
Hide resolved
jjngx
approved these changes
Aug 28, 2023
There was a problem hiding this comment.
👍🏻 @shaun-nx please use shell instead of console. Got this advice from @ADubhlaoich .
Codecov Report
@@ Coverage Diff @@
## main #4294 +/- ##
==========================================
- Coverage 52.20% 52.17% -0.04%
==========================================
Files 59 59
Lines 16930 16930
==========================================
- Hits 8839 8833 -6
- Misses 7794 7798 +4
- Partials 297 299 +2 see 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
vepatel
approved these changes
Aug 29, 2023
ADubhlaoich
approved these changes
Aug 29, 2023
docs/content/tutorials/virtual-server-with-custom-listener-ports.md
Outdated
Show resolved
Hide resolved
docs/content/tutorials/virtual-server-with-custom-listener-ports.md
Outdated
Show resolved
Hide resolved
docs/content/tutorials/virtual-server-with-custom-listener-ports.md
Outdated
Show resolved
Hide resolved
docs/content/tutorials/virtual-server-with-custom-listener-ports.md
Outdated
Show resolved
Hide resolved
This commit changes this tutorial to use tabs for the parallel Helm and Manifest instructions, and also rephrases and restructures both for consistency. There are also some minor changes to rephrase text further down the page.
…ss into docs/vs-and-gc
ADubhlaoich
force-pushed
the
docs/vs-and-gc
branch
from
f59ea69
to
9515357
Compare
ADubhlaoich
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Resolves #4281
This change adds:
This change updates:
Checklist
Before creating a PR, run through this checklist and mark each as complete.