Refactor Helm Chart location #4306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
chore
Codecov Report
@@ Coverage Diff @@
## main #4306 +/- ##
==========================================
- Coverage 52.11% 52.08% -0.03%
==========================================
Files 59 59
Lines 16956 16956
==========================================
- Hits 8836 8832 -4
- Misses 7823 7825 +2
- Partials 297 299 +2 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ADubhlaoich
approved these changes
Aug 30, 2023
jjngx
previously approved these changes
Aug 30, 2023
jjngx
dismissed
their stale review
after standup decision to move the feature to next release
jasonwilliams14
approved these changes
Aug 30, 2023
There was a problem hiding this comment.
Looks good. Changing of folder location.
@lucacome do we need to update anything in our install docs?
|
@jasonwilliams14 there shouldn't be anything else in the docs referencing the chart location. |
|
Hi @lucacome, can you rebase the branch from main and resolve the conflicts please? |
lucacome
force-pushed
the
chore/move-chart-location
branch
from
11ca91e
to
ec76ef1
Compare
|
done @haywoodsh |
jjngx
approved these changes
Sep 25, 2023
shaun-nx
approved these changes
Sep 26, 2023
lucacome
force-pushed
the
chore/move-chart-location
branch
from
000bdeb
to
a2b1013
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
First part of #4287
Moves the helm chart to a more standard location
charts/nginx-ingress.