Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cli-docs and Improve main test #432

Merged
merged 2 commits into from
Nov 12, 2018
Merged

Fix cli-docs and Improve main test #432

merged 2 commits into from
Nov 12, 2018

Conversation

Dean-Coakley
Copy link
Contributor

Proposed changes

  • Fix format of cli-docs
  • Improve main_test.go to be more consistent with other test cases

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@Dean-Coakley Dean-Coakley added enhancement Pull requests for new features/feature enhancements documentation Pull requests/issues for documentation labels Nov 9, 2018
@Dean-Coakley Dean-Coakley self-assigned this Nov 9, 2018
cmd/nginx-ingress/main_test.go Outdated Show resolved Hide resolved
cmd/nginx-ingress/main_test.go Outdated Show resolved Hide resolved
cmd/nginx-ingress/main_test.go Outdated Show resolved Hide resolved
@Dean-Coakley Dean-Coakley force-pushed the improve-test-docs branch 2 times, most recently from 6c3f537 to 08f97ee Compare November 9, 2018 19:51
@Dean-Coakley Dean-Coakley merged commit 8acc7ae into master Nov 12, 2018
@Dean-Coakley Dean-Coakley deleted the improve-test-docs branch November 12, 2018 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants