Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typo in installation / Helm Chart #4335

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Fixed typo in installation / Helm Chart #4335

merged 1 commit into from
Sep 15, 2023

Conversation

fabriziofiorucci
Copy link
Contributor

Proposed changes

Fixed commands typo in https://docs.nginx.com/nginx-ingress-controller/installation/using-the-jwt-token-docker-secret/#helm-chart

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Sep 11, 2023
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Merging #4335 (056cdb8) into main (37ab8d6) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4335      +/-   ##
==========================================
- Coverage   52.19%   52.17%   -0.03%     
==========================================
  Files          59       59              
  Lines       16929    16929              
==========================================
- Hits         8836     8832       -4     
- Misses       7796     7798       +2     
- Partials      297      299       +2     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vepatel vepatel self-requested a review September 12, 2023 08:58
@vepatel
Copy link
Contributor

vepatel commented Sep 12, 2023

@fabriziofiorucci @ADubhlaoich this PR won't be merged as its targeting main from main, please have a look at https://github.com/nginxinc/kubernetes-ingress/blob/main/CONTRIBUTING.md#open-a-pull-request

@brianehlert brianehlert added this to the v3.3.0 milestone Sep 14, 2023
@vepatel
Copy link
Contributor

vepatel commented Sep 15, 2023

@brianehlert can't be merged, see comment above!

@brianehlert
Copy link
Collaborator

@brianehlert can't be merged, see comment above!

Thank you. Removing milestone target.

@brianehlert brianehlert removed this from the v3.3.0 milestone Sep 15, 2023
@lucacome lucacome merged commit fd5bc9c into nginxinc:main Sep 15, 2023
33 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants