Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to proper NGINX Ingress Operator #4348

Merged

Conversation

sigv
Copy link
Contributor

@sigv sigv commented Sep 12, 2023

Proposed changes

In release notes, the old link was to a deprecated repository.
This PR updates it, so that release notes link to the Helm Operator variant.

Closes #4347.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@sigv sigv requested a review from a team as a code owner September 12, 2023 22:01
@sigv sigv force-pushed the release-notes/nginx-ingress-helm-operator branch from a10a7bd to b836504 Compare September 12, 2023 22:01
@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #4348 (a4eac94) into main (ed7780d) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4348      +/-   ##
==========================================
- Coverage   52.19%   52.17%   -0.03%     
==========================================
  Files          59       59              
  Lines       16929    16929              
==========================================
- Hits         8836     8832       -4     
- Misses       7796     7798       +2     
- Partials      297      299       +2     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sigv sigv force-pushed the release-notes/nginx-ingress-helm-operator branch 2 times, most recently from 777a596 to f60ee15 Compare September 14, 2023 10:05
@brianehlert brianehlert added this to the v3.3.0 milestone Sep 14, 2023
Copy link
Contributor

@shaun-nx shaun-nx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this @sigv 👍

In release notes, the old link was to a deprecated repository. This commit updates it, so that release notes link to the Helm Operator variant.

Signed-off-by: Valters Jansons <sigv@users.noreply.github.com>
@sigv sigv force-pushed the release-notes/nginx-ingress-helm-operator branch from f60ee15 to a4eac94 Compare September 15, 2023 08:44
@vepatel vepatel merged commit aba2816 into nginxinc:main Sep 15, 2023
25 of 40 checks passed
@sigv sigv deleted the release-notes/nginx-ingress-helm-operator branch September 15, 2023 13:48
@lucacome lucacome added the documentation Pull requests/issues for documentation label Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Outdated link for Operator in Release Notes
5 participants