-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HPA Custom Behavior #4391
Add HPA Custom Behavior #4391
Conversation
Hi @saedx1 thanks for opening a PR, please make sure to follow https://github.com/nginxinc/kubernetes-ingress/blob/main/CONTRIBUTING.md#open-a-pull-request |
Hi @vepatel , Let me know if an issue is still needed in this case. The proposed change is trivial and does not affect current functionality, however, if you think an issue is needed for further discussion, I will open one. |
@saedx1 Yes would really appreciate, as it helps us prioritise reviews and tests against community PRs :)
|
Done |
Thanks @saedx1! I deployed the helm chart and the HPA resource was configured correctly. |
The right file to update is https://github.com/nginxinc/kubernetes-ingress/blob/main/charts/nginx-ingress/README.md. It's copied automatically to the docs on release. |
- Defines a `controller.autoscaling.behavior` object and defaults it to an empty object `{}`. - References the object in the `templates/controller-hpa.yaml`.
@haywoodsh @lucacome Done :D |
Codecov Report
@@ Coverage Diff @@
## main #4391 +/- ##
==========================================
+ Coverage 51.95% 51.96% +0.01%
==========================================
Files 59 59
Lines 16956 16956
==========================================
+ Hits 8809 8811 +2
+ Misses 7850 7848 -2
Partials 297 297 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@haywoodsh @lucacome Can we merge this? |
This should have a doc change. |
It does. See comments above also |
That will only add it to the readme. This is when I originally implemented the HPA which adds docs so that they will show up in the website. |
@saedx1 could you please update your branch to get it read to be merged? |
@saedx1 Thanks for the contribution and great work! We appreciate it very much!! |
Proposed changes
There is no issue for this pull request. It is a very basic PR.
It adds the ability to define
spec.behavior
for anHorizontalPodAutoscaler
.values.yaml
file; defaults to empty.Checklist
Before creating a PR, run through this checklist and mark each as complete.