Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement issuance of temporary certificate when using VirtualServer cert-manager integration #4409

Merged
merged 1 commit into from
Oct 12, 2023
Merged

implement issuance of temporary certificate when using VirtualServer cert-manager integration #4409

merged 1 commit into from
Oct 12, 2023

Conversation

svvac
Copy link
Contributor

@svvac svvac commented Sep 21, 2023 •
edited

Proposed changes

See #4408

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@svvac svvac requested a review from a team as a code owner September 21, 2023 16:04
@github-actions github-actions bot added the helm_chart Pull requests that update the Helm Chart label Sep 21, 2023
@svvac svvac requested a review from a team as a code owner September 21, 2023 16:11
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Sep 21, 2023
@haywoodsh haywoodsh linked an issue Sep 25, 2023 that may be closed by this pull request
Improve cert manager integration for VirtualServers when using HTTP01 challenges #4408
Closed
@haywoodsh haywoodsh added backlog Pull requests/issues that are backlog items enhancement Pull requests for new features/feature enhancements labels Sep 25, 2023
@codecov
Copy link

codecov bot commented Oct 12, 2023 •
edited

Codecov Report

Merging #4409 (6a8633b) into main (732d174) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4409      +/-   ##
==========================================
+ Coverage   51.95%   51.98%   +0.03%     
==========================================
  Files          59       59              
  Lines       16960    16965       +5     
==========================================
+ Hits         8811     8820       +9     
+ Misses       7852     7850       -2     
+ Partials      297      295       -2
Files Coverage Δ
internal/certmanager/helper.go 88.52% <100.00%> (+1.02%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions github-actions bot removed enhancement Pull requests for new features/feature enhancements helm_chart Pull requests that update the Helm Chart labels Oct 12, 2023
@svvac
Copy link
Contributor Author

svvac commented Oct 12, 2023

Rebased against main.

@jjngx jjngx merged commit d8e9278 into nginxinc:main Oct 12, 2023
62 checks passed
@shaun-nx shaun-nx mentioned this pull request Oct 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ciarams87 ciarams87 ciarams87 approved these changes

@Jcahilltorre Jcahilltorre Jcahilltorre approved these changes

@jjngx jjngx jjngx approved these changes

Assignees
No one assigned
Labels
backlog Pull requests/issues that are backlog items documentation Pull requests/issues for documentation
Projects
NGINX Ingress Controller
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve cert manager integration for VirtualServers when using HTTP01 challenges
5 participants
@svvac @ciarams87 @Jcahilltorre @jjngx @haywoodsh