Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update operator docs for ingressClass #4449

Merged
merged 2 commits into from
Oct 3, 2023

Conversation

haywoodsh
Copy link
Contributor

@haywoodsh haywoodsh commented Oct 2, 2023

Proposed changes

Update operator docs for ingressClass. closes #4433

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Oct 2, 2023
@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Merging #4449 (f7b2a97) into main (be754bc) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4449      +/-   ##
==========================================
+ Coverage   52.08%   52.12%   +0.03%     
==========================================
  Files          59       59              
  Lines       16956    16956              
==========================================
+ Hits         8832     8838       +6     
+ Misses       7825     7821       -4     
+ Partials      299      297       -2     

see 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@haywoodsh haywoodsh marked this pull request as ready for review October 2, 2023 12:35
@haywoodsh haywoodsh requested review from a team as code owners October 2, 2023 12:35
haywoodsh and others added 2 commits October 3, 2023 11:18
Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>

Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>
@haywoodsh haywoodsh force-pushed the docs/update-ingressclass-operator-docs branch from 2fa16e9 to f7b2a97 Compare October 3, 2023 10:18
@haywoodsh haywoodsh merged commit 3e16b62 into main Oct 3, 2023
36 checks passed
@haywoodsh haywoodsh deleted the docs/update-ingressclass-operator-docs branch October 3, 2023 11:09
haywoodsh added a commit that referenced this pull request Oct 5, 2023
* update operator docs for ingressClass
Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>
(cherry picked from commit 3e16b62)
Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Update IC docs for operator to support the ingressClass changes
4 participants