Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use httptest server for running healthcheck tests #4461

Merged
merged 3 commits into from
Oct 3, 2023
Merged

Use httptest server for running healthcheck tests #4461

merged 3 commits into from
Oct 3, 2023

Conversation

jjngx
Copy link
Contributor

@jjngx jjngx commented Oct 3, 2023

Proposed changes

Resolves: #4431
Use server from the httptest pkg for running healtcheck tests.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@jjngx jjngx requested a review from a team as a code owner October 3, 2023 08:49
@github-actions github-actions bot added the tests Pull requests that update tests label Oct 3, 2023
@jjngx jjngx linked an issue Oct 3, 2023 that may be closed by this pull request
@jjngx jjngx added tests Pull requests that update tests and removed tests Pull requests that update tests labels Oct 3, 2023
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #4461 (f78b1aa) into main (3e16b62) will decrease coverage by 0.12%.
The diff coverage is n/a.

❗ Current head f78b1aa differs from pull request most recent head c742e11. Consider uploading reports for the commit c742e11 to get more accurate results

@@            Coverage Diff             @@
##             main    #4461      +/-   ##
==========================================
- Coverage   52.08%   51.97%   -0.12%     
==========================================
  Files          59       59              
  Lines       16956    16956              
==========================================
- Hits         8832     8813      -19     
- Misses       7825     7848      +23     
+ Partials      299      295       -4     

see 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jjngx jjngx requested a review from a team October 3, 2023 09:26
@jjngx jjngx merged commit 6bee233 into main Oct 3, 2023
60 checks passed
@jjngx jjngx deleted the test/helper branch October 3, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Pull requests that update tests
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Port binding issue in the healthcheck package tests
3 participants