Allow default_server listeners to be customised
#4464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
vepatel
reviewed
Oct 3, 2023
Codecov Report
@@ Coverage Diff @@
## main #4464 +/- ##
==========================================
+ Coverage 51.95% 51.96% +0.01%
==========================================
Files 59 59
Lines 16956 16960 +4
==========================================
+ Hits 8809 8813 +4
Misses 7850 7850
Partials 297 297
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jjngx
approved these changes
Oct 3, 2023
|
Please add the parameter in the helm README as well https://github.com/nginxinc/kubernetes-ingress/blob/feat/defaultServerListenerPorts/charts/nginx-ingress/README.md |
shaun-nx
changed the title
default_server listeners to be removed with -disable-default-listeners cli argumentdefault_server listeners to be customised
for more information, see https://pre-commit.ci
Jcahilltorre
approved these changes
Oct 12, 2023
vepatel
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
By default, when deploying the Ingress Controller, there are two
listendirectives that are configured with thedefault_serveroption.This change provides users with an option to customise the ports for both the HTTP and HTTPS
default_serverlistenersThis is useful in scenarios where users must ensure that NGINX does not bind to ports 80 and 443 by default.
Resolves: #4444
Checklist
Before creating a PR, run through this checklist and mark each as complete.