-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow default_server
listeners to be customised
#4464
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4464 +/- ##
==========================================
+ Coverage 51.95% 51.96% +0.01%
==========================================
Files 59 59
Lines 16956 16960 +4
==========================================
+ Hits 8809 8813 +4
Misses 7850 7850
Partials 297 297
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 great stuff, and clean tests 👍🏻
Please add the parameter in the helm README as well https://github.com/nginxinc/kubernetes-ingress/blob/feat/defaultServerListenerPorts/charts/nginx-ingress/README.md |
default_server
listeners to be removed with -disable-default-listeners
cli argumentdefault_server
listeners to be customised
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
Proposed changes
By default, when deploying the Ingress Controller, there are two
listen
directives that are configured with thedefault_server
option.This change provides users with an option to customise the ports for both the HTTP and HTTPS
default_server
listenersThis is useful in scenarios where users must ensure that NGINX does not bind to ports 80 and 443 by default.
Resolves: #4444
Checklist
Before creating a PR, run through this checklist and mark each as complete.