-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 4471: Update README linking to correct complete example #4472
Conversation
The link to the complete-example is broken in the readme at this link: https://github.com/nginxinc/kubernetes-ingress/blob/main/examples/custom-resources/basic-configuration/README.md The README link to "complete example" now points to: https://github.com/nginxinc/kubernetes-ingress/tree/main/examples/ingress-resources/complete-example
Codecov Report
@@ Coverage Diff @@
## main #4472 +/- ##
=======================================
Coverage 51.97% 51.97%
=======================================
Files 59 59
Lines 16956 16956
=======================================
Hits 8813 8813
Misses 7848 7848
Partials 295 295 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
hi @mrajagopal , thank you for your PR. Could you please fix the markdown listing issue? You need to make sure that the line in your editor is not longer than 120 char. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻 LGTM, please make sure the single line is not longer than 120 chars.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good. Once the markdown lint issue is resolved we will merge this. Thanks again!
Co-authored-by: Shaun <s.odonovan@f5.com> Signed-off-by: Madhu Rajagopal <m.rajagopal@f5.com>
for more information, see https://pre-commit.ci
Thanks for the feedback. As best practise, in future, do I 'update branch' or 'update with rebase' for the merge? |
Proposed changes
The link to the complete-example is broken in the readme at this link: https://github.com/nginxinc/kubernetes-ingress/blob/main/examples/custom-resources/basic-configuration/README.md
The README link to "complete example" now points to: https://github.com/nginxinc/kubernetes-ingress/tree/main/examples/ingress-resources/complete-example
Checklist
Before creating a PR, run through this checklist and mark each as complete.