Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Update gc doc with vs listeners (#4492)" #4498

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

vepatel
Copy link
Contributor

@vepatel vepatel commented Oct 11, 2023

Proposed changes

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@vepatel vepatel requested review from a team as code owners October 11, 2023 09:37
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Oct 11, 2023
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #4498 (b4d8d7d) into main (e390768) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4498      +/-   ##
==========================================
+ Coverage   51.95%   51.97%   +0.02%     
==========================================
  Files          59       59              
  Lines       16956    16956              
==========================================
+ Hits         8809     8813       +4     
+ Misses       7850     7848       -2     
+ Partials      297      295       -2     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vepatel vepatel requested a review from shaun-nx October 11, 2023 09:50
@vepatel vepatel merged commit 8880eda into main Oct 11, 2023
62 checks passed
@vepatel vepatel deleted the docs/revert-vs-gc-listener branch October 11, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants