Simplify automated changelog #4525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
shaun-nx
reviewed
Oct 16, 2023
| ## 1.11.0 | ||
|
|
||
| An automatically generated list of changes can be found on GitHub at: [1.11.0 Release](https://github.com/nginxinc/kubernetes-ingress/releases/tag/v1.11.0) | ||
| Starting with version 1.11.0, an automatically generated list of changes can be found on the [GitHub Releases page](https://github.com/nginxinc/kubernetes-ingress/releases). |
There was a problem hiding this comment.
Suggested change
| Starting with version 1.11.0, an automatically generated list of changes can be found on the [GitHub Releases page](https://github.com/nginxinc/kubernetes-ingress/releases). | |
| Starting with version 1.11.0, an automatically generated list of changes can be found on the [GitHub Releases page](https://github.com/nginxinc/kubernetes-ingress/releases). | |
| A curated list of changes can be found on the [Releases](http://docs.nginx.com/nginx-ingress-controller/releases/) page | |
| on the NGINX Documentation website. |
I think it would be useful to keep the link to releases page on our docs as well, since that also will direct the user to the latest release and all other releases.
vepatel
approved these changes
Oct 16, 2023
Codecov Report
@@ Coverage Diff @@
## main #4525 +/- ##
==========================================
- Coverage 52.00% 51.98% -0.02%
==========================================
Files 59 59
Lines 16965 16965
==========================================
- Hits 8822 8820 -2
- Misses 7848 7850 +2
Partials 295 295 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jjngx
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Removes unnecessary entries in the
CHANGELOG. Our changelog is on https://github.com/nginxinc/kubernetes-ingress/releases and http://docs.nginx.com/nginx-ingress-controller/releases/ no need to add a new line inCHANGELOG.mdon every release.