Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update use of http2 listen directive to align with deprecation #4526

Merged
merged 6 commits into from
Oct 17, 2023

Conversation

shaun-nx
Copy link
Contributor

@shaun-nx shaun-nx commented Oct 17, 2023

Proposed changes

As of NGINX 1.25.1, the http2 option for the listen directive has been deprecated.

This change updates our main NGINX, VirtualServer and Ingress templates to enable the new http2 directive in NGINX.

Change this:

listen 443 ssl http2;

To this:

listen 443 ssl;
http2 on;

Resolves #4237

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added the enhancement Pull requests for new features/feature enhancements label Oct 17, 2023
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #4526 (17355aa) into main (5efe0f6) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4526      +/-   ##
==========================================
- Coverage   52.00%   51.98%   -0.02%     
==========================================
  Files          59       59              
  Lines       16965    16965              
==========================================
- Hits         8822     8820       -2     
- Misses       7848     7850       +2     
  Partials      295      295              

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shaun-nx shaun-nx marked this pull request as ready for review October 17, 2023 10:59
@shaun-nx shaun-nx requested a review from a team as a code owner October 17, 2023 10:59
Copy link
Contributor

@jjngx jjngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@github-actions github-actions bot added the tests Pull requests that update tests label Oct 17, 2023
@shaun-nx shaun-nx merged commit 6e48c61 into main Oct 17, 2023
62 checks passed
@shaun-nx shaun-nx deleted the feat/http2-change branch October 17, 2023 17:00
@hanyouqing
Copy link
Contributor

Hi, is this PR included in v3.3.2?

I've upgraded my ingress to v3.3.2 and got the warning, I can't see the PR on the release page. So this is not released yet, right?
Please correct me if I'm wrong.
Thanks!

@vepatel
Copy link
Contributor

vepatel commented Dec 19, 2023

Hi @hanyouqing this is included in v3.4.0 which is released today 👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Pull requests for new features/feature enhancements tests Pull requests that update tests
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Update use of http2 listen directive to align with deprecation
4 participants