Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move static files to scratch image #4551

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Move static files to scratch image #4551

merged 2 commits into from
Nov 3, 2023

Conversation

lucacome
Copy link
Member

Proposed changes

Moves nginx static files to a scratch image.
With ADD --link we can cache the files instead of downloading them every time.
It also removes the need for curl/wget and switches from gpg to https://sequoia-pgp.org/ that has fewer dependencies.

@lucacome lucacome self-assigned this Oct 20, 2023
@lucacome lucacome requested a review from a team as a code owner October 20, 2023 16:00
@github-actions github-actions bot added the chore Pull requests for routine tasks label Oct 20, 2023
@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #4551 (ac72731) into main (e277674) will not change coverage.
The diff coverage is n/a.

❗ Current head ac72731 differs from pull request most recent head d349946. Consider uploading reports for the commit d349946 to get more accurate results

@@           Coverage Diff           @@
##             main    #4551   +/-   ##
=======================================
  Coverage   51.97%   51.97%           
=======================================
  Files          59       59           
  Lines       16962    16962           
=======================================
  Hits         8816     8816           
  Misses       7849     7849           
  Partials      297      297           

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@lucacome lucacome requested a review from a team October 25, 2023 22:39
Copy link
Contributor

@shaun-nx shaun-nx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@lucacome lucacome enabled auto-merge (squash) November 3, 2023 04:06
@lucacome lucacome merged commit 0c8462d into main Nov 3, 2023
32 checks passed
@lucacome lucacome deleted the chore/static-files branch November 3, 2023 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants