Don't throw annotation deprication warning when ingressClassName
is not used in an Ingress resource
#4564
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The below warning message was being thrown when an
Ingress
resource did not have aningressClassName
AND the annotationkubernetes.io/ingress.class
was not used.This warning message should only be displayed when
kubernetes.io/ingress.class
is used ANDingressClassName
is not used.Testing: Confirmed warning message was absent when deploying an Ingress resource with both
ingressClassName
AND the annotationkubernetes.io/ingress.class
missing. This same test was performed for the mergable ingress type (master -minion) to ensure configurations are applied correctly.Resolves #4550
Checklist
Before creating a PR, run through this checklist and mark each as complete.