Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dashboard 2940 #4566

Merged
merged 7 commits into from
Dec 5, 2023
Merged

Fix dashboard 2940 #4566

merged 7 commits into from
Dec 5, 2023

Conversation

hafe
Copy link
Contributor

@hafe hafe commented Oct 25, 2023

Proposed changes

Maintenance of the existing Grafana dashboard. Query values for variables properly and use variables in expressoions where applicable.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • [X ] I have read the CONTRIBUTING doc
  • [ X] I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • [ X] I have rebased my branch onto main
  • [ X] I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@hafe hafe requested a review from a team as a code owner October 25, 2023 17:18
@hafe
Copy link
Contributor Author

hafe commented Oct 31, 2023

Do I need to do something more to get this reviewed?

@brianehlert brianehlert added the backlog Pull requests/issues that are backlog items label Oct 31, 2023
@brianehlert brianehlert added this to the v3.4.0 milestone Oct 31, 2023
@jasonwilliams14
Copy link
Contributor

Do I need to do something more to get this reviewed?

Hey @hafe
We just need to look on our side. I will plan to put this on my todo list this week.

@jasonwilliams14
Copy link
Contributor

Do I need to do something more to get this reviewed?

This looks good @hafe
Thank you for your work on this. We really appreciate it!

@haywoodsh haywoodsh self-assigned this Nov 20, 2023
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c7ccdc9) 52.09% compared to head (9a0f07c) 52.06%.

❗ Current head 9a0f07c differs from pull request most recent head 8f30613. Consider uploading reports for the commit 8f30613 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4566      +/-   ##
==========================================
- Coverage   52.09%   52.06%   -0.03%     
==========================================
  Files          59       59              
  Lines       17033    17033              
==========================================
- Hits         8873     8869       -4     
- Misses       7862     7864       +2     
- Partials      298      300       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@haywoodsh
Copy link
Contributor

Thanks for your contribution @hafe!

@haywoodsh haywoodsh merged commit 37897fc into nginxinc:main Dec 5, 2023
60 checks passed
@hafe hafe deleted the fix-dashboard-2940 branch December 6, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Pull requests/issues that are backlog items
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants