-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dashboard 2940 #4566
Fix dashboard 2940 #4566
Conversation
There is no label kubernetes_pod_name thus it can not work.
1c2b933
to
a6cca38
Compare
Do I need to do something more to get this reviewed? |
Hey @hafe |
This looks good @hafe |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4566 +/- ##
==========================================
- Coverage 52.09% 52.06% -0.03%
==========================================
Files 59 59
Lines 17033 17033
==========================================
- Hits 8873 8869 -4
- Misses 7862 7864 +2
- Partials 298 300 +2 ☔ View full report in Codecov by Sentry. |
Thanks for your contribution @hafe! |
Proposed changes
Maintenance of the existing Grafana dashboard. Query values for variables properly and use variables in expressoions where applicable.
Checklist
Before creating a PR, run through this checklist and mark each as complete.