-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Graduate TransportServer and GlobalConfiguration to v1 #4574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
vepatel
reviewed
Oct 26, 2023
Codecov Report
@@ Coverage Diff @@
## main #4574 +/- ##
==========================================
- Coverage 51.99% 51.97% -0.03%
==========================================
Files 59 59
Lines 16962 16962
==========================================
- Hits 8820 8816 -4
- Misses 7847 7849 +2
- Partials 295 297 +2
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
vepatel
reviewed
Oct 26, 2023
shaun-nx
commented
Oct 26, 2023
vepatel
reviewed
Nov 1, 2023
jjngx
approved these changes
Nov 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
haywoodsh
reviewed
Nov 2, 2023
examples/custom-resources/basic-tcp-udp/transport-server-udp.yaml
Outdated
Show resolved
Hide resolved
haywoodsh
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Pull requests/issues for documentation
enhancement
Pull requests for new features/feature enhancements
tests
Pull requests that update tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Resolves: #4251
This change:
TransportServer
resource fromv1alpha1
tov1
GlobalConfiguration
resource fromv1alpha1
tov1
Testing
v1alpha1
ofTransportServer
andGlobalConfiguration
are not deleted when the new CRD is appliedv1alpha1
ofTransportServer
will operates correctly when new CRD is appliedTransportServer
andGlobalConfiguration
can be deployed side-by-sideTransportServer
will operate correctly. These properties were tested in isolation as they were renamed when being moved fromv1alphav1/types.go
tov1/types.go
:TransportServer
andGlobalConfiguration
pass when deployed asv1alpha1
with using the updated CRDTransportServer
andGlobalConfiguration
pass when deployed asv1
AND using the updated CRDChecklist
Before creating a PR, run through this checklist and mark each as complete.