Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dockerfile for debian N+ #4575

Merged
merged 2 commits into from
Oct 26, 2023
Merged

update dockerfile for debian N+ #4575

merged 2 commits into from
Oct 26, 2023

Conversation

vepatel
Copy link
Contributor

@vepatel vepatel commented Oct 26, 2023

Proposed changes

Fixes #4503 by adding user explicitly

N+

nginx@test-release-nginx-ingress-controller-6b87ddbc7c-6rnpz:/$ cat /etc/passwd
root:x:0:0:root:/root:/bin/bash
.
.
.
nginx:x:101:101:nginx user:/nonexistent:/bin/false

N+ with AP

                    appprotect.f5.com/app-protect-security-log-destination: /var/log/nginx/dev-waftests.log
                    appprotect.f5.com/app-protect-security-log-enable: True
Events:
  Type    Reason          Age   From                      Message
  ----    ------          ----  ----                      -------
  Normal  AddedOrUpdated  108s  nginx-ingress-controller  Configuration for default/cafe-ingress was added or updated
~/nginx/kubernetes-ingress/charts/nginx-ingress on main ● ● λ keti test-release-nginx-ingress-controller-6d94695fdb-58x25 -- bash     
nginx@test-release-nginx-ingress-controller-6d94695fdb-58x25:/$ ls /var/log/nginx/
access.log  dev-waftests.log  error.log

nginx@test-release-nginx-ingress-controller-6d94695fdb-58x25:/$ cat /etc/passwd
root:x:0:0:root:/root:/bin/bash
.
.
.
nginx:x:101:101:nginx user:/nonexistent:/bin/false

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@vepatel vepatel requested a review from a team as a code owner October 26, 2023 15:43
@github-actions github-actions bot added the bug An issue reporting a potential bug label Oct 26, 2023
@vepatel
Copy link
Contributor Author

vepatel commented Oct 26, 2023

cc @sigv

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #4575 (c146ce8) into main (ecec4a6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #4575   +/-   ##
=======================================
  Coverage   51.98%   51.98%           
=======================================
  Files          59       59           
  Lines       16967    16967           
=======================================
  Hits         8820     8820           
  Misses       7852     7852           
  Partials      295      295           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vepatel vepatel merged commit bd3da2c into main Oct 26, 2023
62 checks passed
@vepatel vepatel deleted the fix/update-dockerfile-debian branch October 26, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue reporting a potential bug
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

whoami: cannot find name for user ID 101 after ssh-ing in pod container
3 participants