Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated preview policy flag #4595

Merged
merged 3 commits into from
Nov 1, 2023
Merged

Remove deprecated preview policy flag #4595

merged 3 commits into from
Nov 1, 2023

Conversation

shaun-nx
Copy link
Contributor

@shaun-nx shaun-nx commented Nov 1, 2023

Proposed changes

The -enable-preview-policies flag has been deprecated since the addition of the -enable-oidc flag here

This PR fully removes support for this flag.

Resolves: #4573

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@shaun-nx shaun-nx requested review from a team as code owners November 1, 2023 11:36
@github-actions github-actions bot added documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements helm_chart Pull requests that update the Helm Chart tests Pull requests that update tests labels Nov 1, 2023
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #4595 (5c70c19) into main (bcc392a) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4595      +/-   ##
==========================================
+ Coverage   51.98%   51.99%   +0.01%     
==========================================
  Files          59       59              
  Lines       16967    16962       -5     
==========================================
  Hits         8820     8820              
+ Misses       7852     7847       -5     
  Partials      295      295              
Files Coverage Δ
cmd/nginx-ingress/flags.go 30.88% <ø> (+0.73%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shaun-nx shaun-nx merged commit 74d3aec into main Nov 1, 2023
62 checks passed
@shaun-nx shaun-nx deleted the feat/dep-preview-flag branch November 1, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements helm_chart Pull requests that update the Helm Chart tests Pull requests that update tests
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Remove deprecated preview policy flag
4 participants