-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for backup directive for VS and TS #4653
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4653 +/- ##
==========================================
+ Coverage 51.96% 52.00% +0.03%
==========================================
Files 60 60
Lines 17191 17317 +126
==========================================
+ Hits 8933 9005 +72
- Misses 7954 7999 +45
- Partials 304 313 +9 ☔ View full report in Codecov by Sentry. |
examples/custom-resources/backup-directive/transport-server/README.md
Outdated
Show resolved
Hide resolved
examples/custom-resources/backup-directive/transport-server/README.md
Outdated
Show resolved
Hide resolved
examples/custom-resources/backup-directive/transport-server/README.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM still though I made a number of suggestions in the example README.
I think I got all instances, but for clarity:
- We only need to prepend F5 to the very first mention of NGINX Ingress Controller in a given piece of documentation.
- If we're referring to it as a product or a single instance, we just say "NGINX Ingress Controller": no need to prefix it with "the".
There's some other changes that could be made, but none are blocking, and I will make them myself in the future as part of reviewing the writing in the examples folder.
…ADME.md Co-authored-by: Alan Dooley <ADubhlaoich@users.noreply.github.com> Signed-off-by: Jakub Jarosz <99677300+jjngx@users.noreply.github.com>
…ADME.md Co-authored-by: Alan Dooley <ADubhlaoich@users.noreply.github.com> Signed-off-by: Jakub Jarosz <99677300+jjngx@users.noreply.github.com>
Co-authored-by: Venktesh Shivam Patel <ve.patel@f5.com> Signed-off-by: Jakub Jarosz <99677300+jjngx@users.noreply.github.com>
…e-resources.md Co-authored-by: Venktesh Shivam Patel <ve.patel@f5.com> Signed-off-by: Jakub Jarosz <99677300+jjngx@users.noreply.github.com>
…ADME.md Co-authored-by: Alan Dooley <ADubhlaoich@users.noreply.github.com> Signed-off-by: Jakub Jarosz <99677300+jjngx@users.noreply.github.com>
…ADME.md Co-authored-by: Alan Dooley <ADubhlaoich@users.noreply.github.com> Signed-off-by: Jakub Jarosz <99677300+jjngx@users.noreply.github.com>
…ADME.md Co-authored-by: Alan Dooley <ADubhlaoich@users.noreply.github.com> Signed-off-by: Jakub Jarosz <99677300+jjngx@users.noreply.github.com>
…ADME.md Co-authored-by: Alan Dooley <ADubhlaoich@users.noreply.github.com> Signed-off-by: Jakub Jarosz <99677300+jjngx@users.noreply.github.com>
…ADME.md Co-authored-by: Alan Dooley <ADubhlaoich@users.noreply.github.com> Signed-off-by: Jakub Jarosz <99677300+jjngx@users.noreply.github.com>
for more information, see https://pre-commit.ci
Proposed changes
This PR introduces support for backup directive (external name service) for Transport Server and Virtual Server for NIC Plus.
Checklist
Before creating a PR, run through this checklist and mark each as complete.