-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support weights 0 and 100 in traffic splitting #4655
Support weights 0 and 100 in traffic splitting #4655
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4655 +/- ##
==========================================
- Coverage 51.93% 51.92% -0.01%
==========================================
Files 59 59
Lines 16972 16973 +1
==========================================
- Hits 8814 8813 -1
- Misses 7861 7862 +1
- Partials 297 298 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
@haywoodsh could you add description to the Proposed Changes section?
Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>
Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>
2c669e8
to
227ddfb
Compare
Proposed changes
Allow split traffic's weight value in virtual server to be 0% or 100%.
This change is proposed because "0%" is not currently a valid syntax in
split_clients
. When the value is set to 0%, it will not be included in the generated config, but the effect will be the same as if it were. A value of 100% enables full traffic routing to a particular upstream.Checklist
Before creating a PR, run through this checklist and mark each as complete.