Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update release action to use script #4677

Merged
merged 4 commits into from
Nov 20, 2023
Merged

fix: update release action to use script #4677

merged 4 commits into from
Nov 20, 2023

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Nov 20, 2023

This change updates the release actions to use a script that is easier to test by a developer.

It also updates the location of the helm files in the release scripts and documentation.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

This change updates the release actions to use a script that is easier
to test by a developer.

It also updates the location of the helm files in the release scripts
and documentation.
@pdabelf5 pdabelf5 requested review from a team as code owners November 20, 2023 09:42
@github-actions github-actions bot added documentation Pull requests/issues for documentation helm_chart Pull requests that update the Helm Chart labels Nov 20, 2023
@pdabelf5 pdabelf5 self-assigned this Nov 20, 2023
@pdabelf5 pdabelf5 added enhancement Pull requests for new features/feature enhancements github_actions Pull requests that update Github_actions code good first issue Issues identified as good for first-time contributors labels Nov 20, 2023
@pdabelf5 pdabelf5 added this to the v3.4.0 milestone Nov 20, 2023
@pdabelf5 pdabelf5 linked an issue Nov 20, 2023 that may be closed by this pull request
@github-actions github-actions bot removed the enhancement Pull requests for new features/feature enhancements label Nov 20, 2023
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@8cdaf64). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4677   +/-   ##
=======================================
  Coverage        ?   51.90%           
=======================================
  Files           ?       59           
  Lines           ?    16973           
  Branches        ?        0           
=======================================
  Hits            ?     8809           
  Misses          ?     7864           
  Partials        ?      300           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jjngx jjngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@pdabelf5 pdabelf5 merged commit b056696 into main Nov 20, 2023
36 checks passed
@pdabelf5 pdabelf5 deleted the ingress-version branch November 20, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation github_actions Pull requests that update Github_actions code good first issue Issues identified as good for first-time contributors helm_chart Pull requests that update the Helm Chart
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Update release workflow to target charts/nginx-ingress folder
4 participants