Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README links for building NGINX Ingress Controller images #4700

Merged
merged 4 commits into from
Nov 24, 2023

Conversation

ADubhlaoich
Copy link
Contributor

@ADubhlaoich ADubhlaoich commented Nov 23, 2023

Proposed changes

This commit changes the README links to be the correct, newer link for the document on building NGINX Ingress Controller.

It also makes them the same link: previously, one pointed at the live URL, while the other pointed at the file in the repository.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@ADubhlaoich ADubhlaoich requested a review from a team as a code owner November 23, 2023 10:56
@ADubhlaoich ADubhlaoich self-assigned this Nov 23, 2023
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Nov 23, 2023
Copy link
Contributor

@jjngx jjngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (16af1f6) 51.92% compared to head (a96a3f2) 51.92%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4700   +/-   ##
=======================================
  Coverage   51.92%   51.92%           
=======================================
  Files          59       59           
  Lines       16973    16973           
=======================================
  Hits         8813     8813           
  Misses       7862     7862           
  Partials      298      298           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jjngx jjngx merged commit 637191f into main Nov 24, 2023
62 checks passed
@jjngx jjngx deleted the fix-README-links branch November 24, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants