Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update kind make targets for local & CI use #4704

Merged
merged 8 commits into from
Nov 27, 2023
Merged

update kind make targets for local & CI use #4704

merged 8 commits into from
Nov 27, 2023

Conversation

pdabelf5
Copy link
Collaborator

Proposed changes

Add make targets for interacting with the Kind k8s cluster for both local & CI use

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner November 24, 2023 14:40
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (27ea6b5) 52.06% compared to head (ced5f4a) 52.06%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4704   +/-   ##
=======================================
  Coverage   52.06%   52.06%           
=======================================
  Files          59       59           
  Lines       17033    17033           
=======================================
  Hits         8869     8869           
  Misses       7864     7864           
  Partials      300      300           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jjngx jjngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@jjngx jjngx requested a review from a team November 24, 2023 15:14
@github-actions github-actions bot added the tests Pull requests that update tests label Nov 27, 2023
@pdabelf5 pdabelf5 changed the title add kind make targets to local use update kind make targets for local & CI use Nov 27, 2023
@jjngx jjngx requested a review from a team November 27, 2023 13:42
@jjngx jjngx merged commit f0d831c into main Nov 27, 2023
62 checks passed
@jjngx jjngx deleted the kind-make-target branch November 27, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Pull requests that update tests
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants