Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix tls-passthrough-custom-port test cleanup #4717

Merged
merged 2 commits into from
Nov 29, 2023
Merged

fix tls-passthrough-custom-port test cleanup #4717

merged 2 commits into from
Nov 29, 2023

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Nov 29, 2023 •
edited

Proposed changes

Ensure test tls-passthrough-custom-port cleans up after itself to not impact other tests

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner November 29, 2023 11:54
@github-actions github-actions bot added the tests Pull requests that update tests label Nov 29, 2023
@pdabelf5 pdabelf5 linked an issue Nov 29, 2023 that may be closed by this pull request
Investigate nightly test job failures in pipelines #4659
Closed
@pdabelf5 pdabelf5 self-assigned this Nov 29, 2023
@jjngx jjngx merged commit 1e82d7c into main Nov 29, 2023
60 checks passed
@jjngx jjngx deleted the kind-make-test-fix branch November 29, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haywoodsh haywoodsh haywoodsh approved these changes

@oseoin oseoin oseoin approved these changes

@j1m-ryan j1m-ryan j1m-ryan approved these changes

@shaun-nx shaun-nx shaun-nx approved these changes

Assignees

@pdabelf5 pdabelf5

Labels
tests Pull requests that update tests
Projects
NGINX Ingress Controller
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate nightly test job failures in pipelines
6 participants
@pdabelf5 @haywoodsh @oseoin @j1m-ryan @shaun-nx @jjngx