Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix drift in Prometheus documentation related to ServiceMonitor #4755

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

ADubhlaoich
Copy link
Contributor

Proposed changes

Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to
that issue here in this description (not in the title of the PR).

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@ADubhlaoich ADubhlaoich requested review from a team as code owners December 6, 2023 12:22
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Dec 6, 2023
@ADubhlaoich ADubhlaoich self-assigned this Dec 6, 2023
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4c1eef7) 52.06% compared to head (435a1d7) 52.09%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4755      +/-   ##
==========================================
+ Coverage   52.06%   52.09%   +0.02%     
==========================================
  Files          59       59              
  Lines       17033    17033              
==========================================
+ Hits         8869     8873       +4     
+ Misses       7864     7862       -2     
+ Partials      300      298       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shaun-nx shaun-nx merged commit 112113b into main Dec 6, 2023
62 checks passed
@shaun-nx shaun-nx deleted the docs/fix-prometheus-drift branch December 6, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants