-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs for AppProtect waf bundle #4757
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4757 +/- ##
==========================================
- Coverage 52.09% 52.06% -0.03%
==========================================
Files 59 59
Lines 17033 17033
==========================================
- Hits 8873 8869 -4
- Misses 7862 7864 +2
- Partials 298 300 +2 ☔ View full report in Codecov by Sentry. |
docs/content/installation/installing-nic/installation-with-manifests.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, though I have made one suggestion to add the Hugo note component in the Manifest installation document.
I'm working on the app-protect-waf section at the moment, so once this is merged I will incorporate the new content into my changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
Co-authored-by: Alan Dooley <ADubhlaoich@users.noreply.github.com> Signed-off-by: Venktesh Shivam Patel <ve.patel@f5.com>
for more information, see https://pre-commit.ci
Proposed changes
Checklist
Before creating a PR, run through this checklist and mark each as complete.