Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for AppProtect waf bundle #4757

Merged
merged 4 commits into from
Dec 6, 2023
Merged

Add docs for AppProtect waf bundle #4757

merged 4 commits into from
Dec 6, 2023

Conversation

vepatel
Copy link
Contributor

@vepatel vepatel commented Dec 6, 2023

Proposed changes

  • Add docs for AppProtect waf bundle functionality.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@vepatel vepatel requested review from a team as code owners December 6, 2023 12:40
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Dec 6, 2023
@vepatel vepatel linked an issue Dec 6, 2023 that may be closed by this pull request
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (112113b) 52.09% compared to head (70a3470) 52.06%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4757      +/-   ##
==========================================
- Coverage   52.09%   52.06%   -0.03%     
==========================================
  Files          59       59              
  Lines       17033    17033              
==========================================
- Hits         8873     8869       -4     
- Misses       7862     7864       +2     
- Partials      298      300       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I have made one suggestion to add the Hugo note component in the Manifest installation document.

I'm working on the app-protect-waf section at the moment, so once this is merged I will incorporate the new content into my changes.

Copy link
Contributor

@jjngx jjngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

vepatel and others added 3 commits December 6, 2023 13:49
Co-authored-by: Alan Dooley <ADubhlaoich@users.noreply.github.com>
Signed-off-by: Venktesh Shivam Patel <ve.patel@f5.com>
@vepatel vepatel merged commit 12045f5 into main Dec 6, 2023
62 checks passed
@vepatel vepatel deleted the docs/waf-bundle branch December 6, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add WAF Bundle Example Docs
3 participants