Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update prometheus exporter to 1.0.0 #4769

Merged
merged 6 commits into from
Dec 12, 2023
Merged

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Dec 8, 2023

Proposed changes

Update the the Prometheus Exporter to 1.0.0

  • Update go nginx-prometheus-exporter library
  • Update code to reflect nginx-prometheus-exporter function signature updates for 1.0.0

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner December 8, 2023 10:21
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Dec 8, 2023
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (c2945be) 52.13% compared to head (6f03dc1) 52.09%.

Files Patch % Lines
cmd/nginx-ingress/main.go 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4769      +/-   ##
==========================================
- Coverage   52.13%   52.09%   -0.05%     
==========================================
  Files          59       59              
  Lines       17098    17100       +2     
==========================================
- Hits         8914     8908       -6     
- Misses       7886     7892       +6     
- Partials      298      300       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pdabelf5 pdabelf5 self-assigned this Dec 8, 2023
@pdabelf5 pdabelf5 added this to the v3.4.1 milestone Dec 11, 2023
@jjngx jjngx requested a review from a team December 11, 2023 11:27
@github-actions github-actions bot added the tests Pull requests that update tests label Dec 12, 2023
@pdabelf5 pdabelf5 merged commit a122d11 into main Dec 12, 2023
62 checks passed
@pdabelf5 pdabelf5 deleted the update-prometheus-exporter branch December 12, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file tests Pull requests that update tests
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants