realign makefile variable to be more readable #4783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4783 +/- ##
==========================================
+ Coverage 52.00% 52.02% +0.02%
==========================================
Files 60 60
Lines 17317 17317
==========================================
+ Hits 9005 9009 +4
+ Misses 7999 7997 -2
+ Partials 313 311 -2 ☔ View full report in Codecov by Sentry. |
oseoin
approved these changes
Dec 12, 2023
jjngx
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Align Makefile variables to be more readable
Add ability to choose ARCH & OS of resulting binary
Checklist
Before creating a PR, run through this checklist and mark each as complete.