Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split appProtect tests to speed up pipeline #4784

Merged
merged 8 commits into from
Dec 12, 2023
Merged

split appProtect tests to speed up pipeline #4784

merged 8 commits into from
Dec 12, 2023

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Dec 12, 2023

Proposed changes

Add markers:

@pytest.mark.appprotect_integration
@pytest.mark.appprotect_waf_policies
@pytest.mark.appprotect_waf_policies_allow
@pytest.mark.appprotect_waf_policies_grpc
@pytest.mark.appprotect_watch
@pytest.mark.appprotect_batch

Update the CI.yml workflow file to create jobs for these individual markers rather than one whole @pytest.mark.appprotect marker. Leave the @pytest.mark.appprotect in place for future use.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner December 12, 2023 12:35
@github-actions github-actions bot added the tests Pull requests that update tests label Dec 12, 2023
@pdabelf5 pdabelf5 self-assigned this Dec 12, 2023
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bd29988) 51.96% compared to head (8e630a8) 51.96%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4784   +/-   ##
=======================================
  Coverage   51.96%   51.96%           
=======================================
  Files          60       60           
  Lines       17191    17191           
=======================================
  Hits         8933     8933           
  Misses       7954     7954           
  Partials      304      304           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@shaun-nx shaun-nx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚤

@pdabelf5 pdabelf5 merged commit 5e0bd5c into main Dec 12, 2023
66 checks passed
@pdabelf5 pdabelf5 deleted the nap-test-markers branch December 12, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Pull requests that update tests
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants