-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lazy loading OSS #4788
Lazy loading OSS #4788
Conversation
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4788 +/- ##
==========================================
+ Coverage 52.00% 52.01% +0.01%
==========================================
Files 60 60
Lines 17317 17313 -4
==========================================
Hits 9005 9005
+ Misses 7999 7995 -4
Partials 313 313 ☔ View full report in Codecov by Sentry. |
docs/content/configuration/global-configuration/command-line-arguments.md
Outdated
Show resolved
Hide resolved
Hi @oseoin, I think the phrasing in the helm chart docs has to be changed as well.
https://github.com/nginxinc/kubernetes-ingress/blob/main/charts/nginx-ingress/values.yaml#L466
Also, docs missing |
Proposed changes
Update changes in 4764 to remove incorrect Plus requirement for lazy loading of certificates.
Checklist
Before creating a PR, run through this checklist and mark each as complete.