Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and update links in VirtualServer port tutorial #4792

Merged
merged 4 commits into from
Dec 14, 2023

Conversation

ADubhlaoich
Copy link
Contributor

@ADubhlaoich ADubhlaoich commented Dec 13, 2023

Proposed changes

This commit fixes a broken link in the VirtualServer tutorial for custom ports that was intended to point at the repository's example folder. While addressing this change, I also updated the other links to become relative references to avoid other issues.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

This commit fixes a broken link in the VirtualServer tutorial for custom
ports that was intended to point at the repository's example folder.
While addressing this change, I also updated the other links to become
relative references to avoid other issues.
@ADubhlaoich ADubhlaoich requested review from a team as code owners December 13, 2023 12:00
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Dec 13, 2023
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6013e57) 52.01% compared to head (3dc6546) 52.03%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4792      +/-   ##
==========================================
+ Coverage   52.01%   52.03%   +0.02%     
==========================================
  Files          60       60              
  Lines       17313    17313              
==========================================
+ Hits         9005     9009       +4     
+ Misses       7995     7993       -2     
+ Partials      313      311       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ADubhlaoich ADubhlaoich self-assigned this Dec 13, 2023
@ADubhlaoich ADubhlaoich enabled auto-merge (squash) December 13, 2023 12:12
@ADubhlaoich ADubhlaoich merged commit b84e64f into main Dec 14, 2023
66 checks passed
@ADubhlaoich ADubhlaoich deleted the docs/fix-broken-tutorial-link branch December 14, 2023 10:44
ADubhlaoich added a commit to ADubhlaoich/nic-doc-work that referenced this pull request Dec 27, 2023
This commit fixes a broken link in the VirtualServer tutorial for custom
ports that was intended to point at the repository's example folder.
While addressing this change, I also updated the other links to become
relative references to avoid other issues.
ADubhlaoich added a commit to ADubhlaoich/nic-doc-work that referenced this pull request Dec 27, 2023
This commit fixes a broken link in the VirtualServer tutorial for custom
ports that was intended to point at the repository's example folder.
While addressing this change, I also updated the other links to become
relative references to avoid other issues.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants