-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix and update links in VirtualServer port tutorial #4792
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a broken link in the VirtualServer tutorial for custom ports that was intended to point at the repository's example folder. While addressing this change, I also updated the other links to become relative references to avoid other issues.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4792 +/- ##
==========================================
+ Coverage 52.01% 52.03% +0.02%
==========================================
Files 60 60
Lines 17313 17313
==========================================
+ Hits 9005 9009 +4
+ Misses 7995 7993 -2
+ Partials 313 311 -2 ☔ View full report in Codecov by Sentry. |
Jcahilltorre
approved these changes
Dec 13, 2023
vepatel
approved these changes
Dec 14, 2023
ADubhlaoich
added a commit
to ADubhlaoich/nic-doc-work
that referenced
this pull request
Dec 27, 2023
This commit fixes a broken link in the VirtualServer tutorial for custom ports that was intended to point at the repository's example folder. While addressing this change, I also updated the other links to become relative references to avoid other issues.
ADubhlaoich
added a commit
to ADubhlaoich/nic-doc-work
that referenced
this pull request
Dec 27, 2023
This commit fixes a broken link in the VirtualServer tutorial for custom ports that was intended to point at the repository's example folder. While addressing this change, I also updated the other links to become relative references to avoid other issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This commit fixes a broken link in the VirtualServer tutorial for custom ports that was intended to point at the repository's example folder. While addressing this change, I also updated the other links to become relative references to avoid other issues.
Checklist
Before creating a PR, run through this checklist and mark each as complete.