Update vs backup service tests with retries #4797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
vepatel
reviewed
Dec 14, 2023
jjngx
approved these changes
Dec 14, 2023
vepatel
reviewed
Dec 14, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4797 +/- ##
=======================================
Coverage 52.03% 52.03%
=======================================
Files 60 60
Lines 17313 17313
=======================================
Hits 9009 9009
Misses 7993 7993
Partials 311 311 ☔ View full report in Codecov by Sentry. |
vepatel
approved these changes
Dec 14, 2023
oseoin
approved these changes
Dec 14, 2023
jjngx
pushed a commit
that referenced
this pull request
Dec 14, 2023
j1m-ryan
pushed a commit
that referenced
this pull request
Dec 15, 2023
jjngx
added a commit
that referenced
this pull request
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Updates
test_virtual_server_backup_servicetests with retries when asserting that the backup services is in the upstreamChecklist
Before creating a PR, run through this checklist and mark each as complete.