Fix HSTS header over non tls ingresses #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add HSTSBehindProxy annotation * Add HSTSBehindProxy configmap entry * Update ConfigMap/Annotations docs * Update OSS/Plus ingress templates * HSTS headers now added on redirects over https
pleshakov
suggested changes
Jan 24, 2019
| {{- if $server.RedirectToHTTPS}} | ||
| if ($http_x_forwarded_proto = 'http') { | ||
| return 301 https://$host$request_uri; | ||
| } | ||
| {{- end}} | ||
|
|
||
| {{- if $server.SSLRedirect}} |
There was a problem hiding this comment.
the SSL redirect part here must go into the following block
{{if $server.SSL}}
{{if not $server.GRPCOnly}}
<here, after hsts stuff>
{{end}}
{{end}}
Otherwise it is a BUG, because the redirect will be enabled for Ingress resources without any TLS termination.
Please double check that for an Ingress resource without TLS termination, no SSL redirect is generated.
There was a problem hiding this comment.
same for nginx oss template
Rulox
approved these changes
Jan 24, 2019
pleshakov
approved these changes
Jan 25, 2019
Dean-Coakley
added a commit
that referenced
this pull request
Jan 31, 2019
nginx-controller binary was mistakenly added in #481 This PR removes the binary again
4 tasks
Dean-Coakley
added a commit
that referenced
this pull request
Jan 31, 2019
nginx-controller binary was mistakenly added in #481 This PR removes the binary again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #404
Proposed changes
Checklist
Before creating a PR, run through this checklist and mark each as complete.